Review Request 128340: Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128340/#review97009
-----------------------------------------------------------



Thanks for the very quick fix. Unfortunately I don't know enough about QQuickWidget to approve.

Just wondering: in the testing section, you don't mention that you actually tested runtime behaviour with this change? ;)


src/kcmoduleqml.cpp (line 112)
<https://git.reviewboard.kde.org/r/128340/#comment65545>

    While you're here, this particular check can be removed, Qt 5.4 is required.


- David Faure


On July 2, 2016, 8:44 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128340/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 8:44 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> Fixes build with Qt 5.4 after 23b6468fc2486516711ba4ce50f3492fd231d50e
> 
> 
> Diffs
> -----
> 
>   src/kcmoduleqml.cpp 232998f 
> 
> Diff: https://git.reviewboard.kde.org/r/128340/diff/
> 
> 
> Testing
> -------
> 
> Should build fine with Qt 5.4 according to docs. Not tested myself though.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160702/d0e35576/attachment.html>