Review Request 126772: Fix some Clazy warnings in KService

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126772/#review91217
-----------------------------------------------------------



Please fix those, just some nitpicking.

Otherwise, +1.


src/kbuildsycoca/kbuildsycoca_main.cpp (line 55)
<https://git.reviewboard.kde.org/r/126772/#comment62241>

    You can probably do this in `src/sycoca/ksycoca.h:37`, this way it only needs to be done once.



src/services/kplugininfo.cpp (line 184)
<https://git.reviewboard.kde.org/r/126772/#comment62242>

    Should be QLatin1String


- Aleix Pol Gonzalez


On Jan. 16, 2016, 10:06 p.m., Andrey Cygankov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126772/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 10:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Fix some Clazy warnings in KService.
> 
> 
> Diffs
> -----
> 
>   autotests/kautostarttest.cpp 1949baa 
>   autotests/kmimeassociationstest.cpp 60818f7 
>   autotests/kplugininfotest.cpp 9ddc8cf 
>   autotests/kservicetest.cpp 6dc6f98 
>   autotests/ksycoca_xdgdirstest.cpp f879959 
>   autotests/ksycocadicttest.cpp 302853d 
>   autotests/ksycocatest.cpp 4af759c 
>   autotests/ksycocathreadtest.cpp fba9cae 
>   autotests/pluginlocatortest.cpp 528a2a5 
>   src/kbuildsycoca/kbuildsycoca_main.cpp 03619cc 
>   src/kdeinit/ktoolinvocation_x11.cpp 58f2c7f 
>   src/services/kautostart.cpp 86f0270 
>   src/services/kmimetypetrader.h 6882b75 
>   src/services/kplugininfo.cpp 3627fe8 
>   src/services/kservice.cpp 5bbca9a 
>   src/services/kservicegroup.cpp 54cace5 
>   src/services/kservicetype.cpp 5f66f51 
>   src/services/kservicetypeprofile.cpp c22645b 
>   src/sycoca/kbuildmimetypefactory.cpp 5d32b35 
>   src/sycoca/kbuildservicefactory.cpp dd81860 
>   src/sycoca/kbuildservicetypefactory.cpp bf5e663 
>   src/sycoca/kbuildsycoca.cpp 650526b 
>   src/sycoca/kmimeassociations.cpp 922a447 
>   src/sycoca/ksycoca.cpp 5744e95 
>   src/sycoca/ksycocautils_p.h caeb0e0 
>   src/sycoca/vfolder_menu.cpp d3e31c3 
>   tests/kdbusservicestartertest.cpp 8174485 
>   tests/pluginlocator/main.cpp f1dcfae 
>   tests/pluginlocator/plugintest.h ab41c7c 
>   tests/pluginlocator/plugintest.cpp 82df4dc 
>   tests/startserviceby.cpp 1a683b3 
> 
> Diff: https://git.reviewboard.kde.org/r/126772/diff/
> 
> 
> Testing
> -------
> 
> Built without errors.
> 
> Without patch: Failed kmimeassociationstest
> With patch: Failed kmimeassociationstest
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160117/5188b047/attachment.html>