<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126772/">https://git.reviewboard.kde.org/r/126772/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please fix those, just some nitpicking.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise, +1.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126772/diff/1/?file=431848#file431848line55" style="color: black; font-weight: bold; text-decoration: underline;">src/kbuildsycoca/kbuildsycoca_main.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAboutData</span> <span class="n">about</span><span class="p">(</span><span class="n">KBUILDSYCOCA_EXENAME</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">KAboutData</span> <span class="n">about</span><span class="p">(</span><span class="n"><span class="hl">QStringLiteral</span></span><span class="p"><span class="hl">(</span></span><span class="n">KBUILDSYCOCA_EXENAME</span><span class="p"><span class="hl">)</span>,</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You can probably do this in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">src/sycoca/ksycoca.h:37</code>, this way it only needs to be done once.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126772/diff/1/?file=431852#file431852line184" style="color: black; font-weight: bold; text-decoration: underline;">src/services/kplugininfo.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">184</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">enabledByDefault</span> <span class="o">=</span> <span class="n">enabledByDefault</span><span class="p">.</span><span class="n">toString</span><span class="p">().</span><span class="n">compare</span><span class="p">(</span><span class="s">"true"</span><span class="p">,</span> <span class="n">Qt</span><span class="o">::</span><span class="n">CaseInsensitive</span><span class="p">)</span> <span class="o">==</span> <span class="mi">0</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">184</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">enabledByDefault</span> <span class="o">=</span> <span class="n">enabledByDefault</span><span class="p">.</span><span class="n">toString</span><span class="p">().</span><span class="n">compare</span><span class="p">(</span><span class="n"><span class="hl">QStringLiteral</span></span><span class="p"><span class="hl">(</span></span><span class="s">"true"</span><span class="p"><span class="hl">)</span>,</span> <span class="n">Qt</span><span class="o">::</span><span class="n">CaseInsensitive</span><span class="p">)</span> <span class="o">==</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should be QLatin1String</p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On January 16th, 2016, 10:06 p.m. CET, Andrey Cygankov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Andrey Cygankov.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2016, 10:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix some Clazy warnings in KService.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built without errors.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Without patch: Failed kmimeassociationstest
With patch: Failed kmimeassociationstest</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kautostarttest.cpp <span style="color: grey">(1949baa)</span></li>
<li>autotests/kmimeassociationstest.cpp <span style="color: grey">(60818f7)</span></li>
<li>autotests/kplugininfotest.cpp <span style="color: grey">(9ddc8cf)</span></li>
<li>autotests/kservicetest.cpp <span style="color: grey">(6dc6f98)</span></li>
<li>autotests/ksycoca_xdgdirstest.cpp <span style="color: grey">(f879959)</span></li>
<li>autotests/ksycocadicttest.cpp <span style="color: grey">(302853d)</span></li>
<li>autotests/ksycocatest.cpp <span style="color: grey">(4af759c)</span></li>
<li>autotests/ksycocathreadtest.cpp <span style="color: grey">(fba9cae)</span></li>
<li>autotests/pluginlocatortest.cpp <span style="color: grey">(528a2a5)</span></li>
<li>src/kbuildsycoca/kbuildsycoca_main.cpp <span style="color: grey">(03619cc)</span></li>
<li>src/kdeinit/ktoolinvocation_x11.cpp <span style="color: grey">(58f2c7f)</span></li>
<li>src/services/kautostart.cpp <span style="color: grey">(86f0270)</span></li>
<li>src/services/kmimetypetrader.h <span style="color: grey">(6882b75)</span></li>
<li>src/services/kplugininfo.cpp <span style="color: grey">(3627fe8)</span></li>
<li>src/services/kservice.cpp <span style="color: grey">(5bbca9a)</span></li>
<li>src/services/kservicegroup.cpp <span style="color: grey">(54cace5)</span></li>
<li>src/services/kservicetype.cpp <span style="color: grey">(5f66f51)</span></li>
<li>src/services/kservicetypeprofile.cpp <span style="color: grey">(c22645b)</span></li>
<li>src/sycoca/kbuildmimetypefactory.cpp <span style="color: grey">(5d32b35)</span></li>
<li>src/sycoca/kbuildservicefactory.cpp <span style="color: grey">(dd81860)</span></li>
<li>src/sycoca/kbuildservicetypefactory.cpp <span style="color: grey">(bf5e663)</span></li>
<li>src/sycoca/kbuildsycoca.cpp <span style="color: grey">(650526b)</span></li>
<li>src/sycoca/kmimeassociations.cpp <span style="color: grey">(922a447)</span></li>
<li>src/sycoca/ksycoca.cpp <span style="color: grey">(5744e95)</span></li>
<li>src/sycoca/ksycocautils_p.h <span style="color: grey">(caeb0e0)</span></li>
<li>src/sycoca/vfolder_menu.cpp <span style="color: grey">(d3e31c3)</span></li>
<li>tests/kdbusservicestartertest.cpp <span style="color: grey">(8174485)</span></li>
<li>tests/pluginlocator/main.cpp <span style="color: grey">(f1dcfae)</span></li>
<li>tests/pluginlocator/plugintest.h <span style="color: grey">(ab41c7c)</span></li>
<li>tests/pluginlocator/plugintest.cpp <span style="color: grey">(82df4dc)</span></li>
<li>tests/startserviceby.cpp <span style="color: grey">(1a683b3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126772/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>