Review Request 126765: Fix some Clazy warnings in KTextEditor.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126765/#review91176
-----------------------------------------------------------



All in all, it looks quite good. Here's some nitpicks that would be nice if you could fix.

Otherwise, +1, waiting for a maintainer to give the final "ship it".


src/view/kateviewhelpers.cpp (line 1637)
<https://git.reviewboard.kde.org/r/126765/#comment62202>

    Use `QString::number(realLine+1)`



src/view/kateviewhelpers.cpp (line 1640)
<https://git.reviewboard.kde.org/r/126765/#comment62203>

    Use `QString::number(distanceToCurrent)`



src/view/kateviewhelpers.cpp (line 1648)
<https://git.reviewboard.kde.org/r/126765/#comment62201>

    Use `QString::number(realLine+1)`



src/vimode/macros.cpp (line 150)
<https://git.reviewboard.kde.org/r/126765/#comment62204>

    `remove(QLatin1Char('|'))`


- Aleix Pol Gonzalez


On Jan. 16, 2016, 1:26 p.m., Andrey Cygankov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126765/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 1:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> -------
> 
> Fix some Clazy warnings in KTextEditor.
> 
> 
> Diffs
> -----
> 
>   autotests/src/bug205447.cpp a6c6c23 
>   autotests/src/bug313759.cpp 9763454 
>   autotests/src/bug313769.cpp c011345 
>   autotests/src/bug317111.cpp ec6a5d1 
>   autotests/src/commands_test.cpp 5a0e4c4 
>   autotests/src/completion_test.cpp 919c2cb 
>   autotests/src/testutils.cpp 06c22bf 
>   src/buffer/katetextbuffer.cpp e7397c9 
>   src/buffer/katetextfolding.cpp 54d407a 
>   src/buffer/katetextloader.h 84d420a 
>   src/completion/expandingtree/expandingdelegate.cpp 7eb03c5 
>   src/completion/expandingtree/expandingwidgetmodel.cpp f4cad7a 
>   src/completion/katecompletionconfig.cpp c0494ff 
>   src/completion/katecompletionmodel.cpp b48c91c 
>   src/completion/katekeywordcompletion.cpp f1ad42c 
>   src/completion/katewordcompletion.cpp 925b381 
>   src/dialogs/katedialogs.cpp 0d44f97 
>   src/document/katedocument.cpp ef96a17 
>   src/export/abstractexporter.h cc014dd 
>   src/export/htmlexporter.cpp 7736a71 
>   src/inputmode/kateviinputmode.cpp 1954b2e 
>   src/mode/katemodeconfigpage.cpp 42a75de 
>   src/mode/katemodemanager.cpp 641067f 
>   src/printing/printconfigwidgets.cpp b082983 
>   src/printing/printpainter.cpp 8368f9e 
>   src/render/katelayoutcache.cpp 957006c 
>   src/render/katerenderer.cpp b108e10 
>   src/schema/katecolortreewidget.cpp 5b6c32c 
>   src/schema/kateschema.cpp 90c91ef 
>   src/schema/kateschemaconfig.cpp 082fce6 
>   src/schema/katestyletreewidget.cpp e167ceb 
>   src/script/katecommandlinescript.cpp afa3efa 
>   src/script/kateindentscript.cpp 2050d4f 
>   src/script/katescript.cpp 3dbc2e1 
>   src/script/katescriptaction.cpp bf0984e 
>   src/script/katescriptdocument.cpp c5a1784 
>   src/script/katescripthelpers.cpp c078614 
>   src/script/katescriptmanager.cpp 4c416d4 
>   src/search/kateplaintextsearch.cpp 5a36577 
>   src/search/kateregexp.cpp 1431f95 
>   src/search/kateregexpsearch.cpp 8eb374b 
>   src/search/katesearchbar.cpp 2e1ee99 
>   src/spellcheck/spellcheckdialog.cpp 531d24f 
>   src/spellcheck/spellingmenu.cpp 2319680 
>   src/swapfile/kateswapdiffcreator.cpp ac09363 
>   src/swapfile/kateswapfile.cpp f716af9 
>   src/syntax/data/katehighlightingindexer.cpp d9b0d65 
>   src/syntax/katehighlight.cpp c3412f7 
>   src/syntax/katehighlighthelpers.cpp e953d23 
>   src/syntax/katehighlightingcmds.h 802c0f9 
>   src/syntax/katesyntaxdocument.cpp 15d629b 
>   src/syntax/katesyntaxmanager.cpp 4d09fa3 
>   src/undo/kateundomanager.cpp cc7366c 
>   src/utils/attribute.cpp 130c496 
>   src/utils/katebookmarks.cpp 2fcf924 
>   src/utils/katecmd.cpp 462d4fd 
>   src/utils/katecmds.h d02e700 
>   src/utils/katecmds.cpp 2fd3a38 
>   src/utils/katecommandrangeexpressionparser.cpp f57cb45 
>   src/utils/kateconfig.cpp abf30cc 
>   src/utils/kateglobal.cpp 66b70e2 
>   src/utils/katesedcmd.h eb61d32 
>   src/utils/katesedcmd.cpp 062a65e 
>   src/utils/ktexteditor.cpp 815a40e 
>   src/variableeditor/katehelpbutton.cpp a0e1914 
>   src/variableeditor/variableitem.cpp b0e0a7b 
>   src/variableeditor/variablelineedit.cpp 2a1af83 
>   src/variableeditor/variablelistview.cpp 7316a7f 
>   src/view/kateview.cpp 7e828fe 
>   src/view/kateviewhelpers.cpp fc171f3 
>   src/view/kateviewinternal.cpp f968a87 
>   src/vimode/appcommands.cpp 2708487 
>   src/vimode/cmds.h 03fc39f 
>   src/vimode/cmds.cpp 7804af4 
>   src/vimode/commandrangeexpressionparser.cpp 94e00c5 
>   src/vimode/config/configtab.cpp 8074327 
>   src/vimode/emulatedcommandbar.cpp e876b7a 
>   src/vimode/inputmodemanager.cpp 5f797a0 
>   src/vimode/keyparser.cpp 99f6fbf 
>   src/vimode/lastchangerecorder.cpp e7b4d43 
>   src/vimode/macros.cpp b96c099 
>   src/vimode/mappings.cpp 82388cf 
>   src/vimode/modes/insertvimode.cpp ed71cd4 
>   src/vimode/modes/modebase.cpp 5016b96 
>   src/vimode/modes/normalvimode.cpp c0eaf40 
>   src/vimode/modes/visualvimode.cpp c58277b 
>   src/vimode/searcher.cpp 133ff9b 
> 
> Diff: https://git.reviewboard.kde.org/r/126765/diff/
> 
> 
> Testing
> -------
> 
> Built without errors.
> All tests passed.
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160116/5645da28/attachment-0001.html>