<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126765/">https://git.reviewboard.kde.org/r/126765/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All in all, it looks quite good. Here's some nitpicks that would be nice if you could fix.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise, +1, waiting for a maintainer to give the final "ship it".</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126765/diff/1/?file=431539#file431539line1637" style="color: black; font-weight: bold; text-decoration: underline;">src/view/kateviewhelpers.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1637</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Qt</span><span class="o">::</span><span class="n">TextDontClip</span><span class="o">|</span><span class="n">Qt</span><span class="o">::</span><span class="n">AlignLeft</span><span class="o">|</span><span class="n">Qt</span><span class="o">::</span><span class="n">AlignVCenter</span><span class="p">,</span> <span class="n">QString</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLatin1</span></span><span class="p">(</span><span class="s">"%1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">realLine</span> <span class="o">+</span> <span class="mi">1</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1637</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Qt</span><span class="o">::</span><span class="n">TextDontClip</span><span class="o">|</span><span class="n">Qt</span><span class="o">::</span><span class="n">AlignLeft</span><span class="o">|</span><span class="n">Qt</span><span class="o">::</span><span class="n">AlignVCenter</span><span class="p">,</span> <span class="n">QString<span class="hl">Literal</span></span><span class="p">(</span><span class="s">"%1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">realLine</span> <span class="o">+</span> <span class="mi">1</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QString::number(realLine+1)</code></p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126765/diff/1/?file=431539#file431539line1640" style="color: black; font-weight: bold; text-decoration: underline;">src/view/kateviewhelpers.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1640</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Qt</span><span class="o">::</span><span class="n">TextDontClip</span><span class="o">|</span><span class="n">Qt</span><span class="o">::</span><span class="n">AlignRight</span><span class="o">|</span><span class="n">Qt</span><span class="o">::</span><span class="n">AlignVCenter</span><span class="p">,</span> <span class="n">QString</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLatin1</span></span><span class="p">(</span><span class="s">"%1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">distanceToCurrent</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1640</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Qt</span><span class="o">::</span><span class="n">TextDontClip</span><span class="o">|</span><span class="n">Qt</span><span class="o">::</span><span class="n">AlignRight</span><span class="o">|</span><span class="n">Qt</span><span class="o">::</span><span class="n">AlignVCenter</span><span class="p">,</span> <span class="n">QString<span class="hl">Literal</span></span><span class="p">(</span><span class="s">"%1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">distanceToCurrent</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QString::number(distanceToCurrent)</code></p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126765/diff/1/?file=431539#file431539line1648" style="color: black; font-weight: bold; text-decoration: underline;">src/view/kateviewhelpers.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1648</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Qt</span><span class="o">::</span><span class="n">TextDontClip</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">AlignRight</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">AlignVCenter</span><span class="p">,</span> <span class="n">QString</span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLatin1</span></span><span class="p">(</span><span class="s">"%1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">realLine</span> <span class="o">+</span> <span class="mi">1</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1648</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Qt</span><span class="o">::</span><span class="n">TextDontClip</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">AlignRight</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">AlignVCenter</span><span class="p">,</span> <span class="n">QString<span class="hl">Literal</span></span><span class="p">(</span><span class="s">"%1"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">realLine</span> <span class="o">+</span> <span class="mi">1</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QString::number(realLine+1)</code></p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126765/diff/1/?file=431550#file431550line150" style="color: black; font-weight: bold; text-decoration: underline;">src/vimode/macros.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">150</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">completionText</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="s">"(...)"</span><span class="p">),</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"()"</span><span class="p">)).</span><span class="n">remove</span><span class="p">(</span><span class="n">Q<span class="hl">Latin1</span>String</span><span class="p">(</span><span class="s">"|"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">150</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">completionText</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="n">QLatin1String</span><span class="p">(</span><span class="s">"(...)"</span><span class="p">),</span> <span class="n">QLatin1String</span><span class="p">(</span><span class="s">"()"</span><span class="p">)).</span><span class="n">remove</span><span class="p">(</span><span class="n">QString<span class="hl">Literal</span></span><span class="p">(</span><span class="s">"|"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">remove(QLatin1Char('|'))</code></p></pre>
</div>
</div>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On January 16th, 2016, 1:26 p.m. CET, Andrey Cygankov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aleix Pol Gonzalez.</div>
<div>By Andrey Cygankov.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2016, 1:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix some Clazy warnings in KTextEditor.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Built without errors.
All tests passed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/src/bug205447.cpp <span style="color: grey">(a6c6c23)</span></li>
<li>autotests/src/bug313759.cpp <span style="color: grey">(9763454)</span></li>
<li>autotests/src/bug313769.cpp <span style="color: grey">(c011345)</span></li>
<li>autotests/src/bug317111.cpp <span style="color: grey">(ec6a5d1)</span></li>
<li>autotests/src/commands_test.cpp <span style="color: grey">(5a0e4c4)</span></li>
<li>autotests/src/completion_test.cpp <span style="color: grey">(919c2cb)</span></li>
<li>autotests/src/testutils.cpp <span style="color: grey">(06c22bf)</span></li>
<li>src/buffer/katetextbuffer.cpp <span style="color: grey">(e7397c9)</span></li>
<li>src/buffer/katetextfolding.cpp <span style="color: grey">(54d407a)</span></li>
<li>src/buffer/katetextloader.h <span style="color: grey">(84d420a)</span></li>
<li>src/completion/expandingtree/expandingdelegate.cpp <span style="color: grey">(7eb03c5)</span></li>
<li>src/completion/expandingtree/expandingwidgetmodel.cpp <span style="color: grey">(f4cad7a)</span></li>
<li>src/completion/katecompletionconfig.cpp <span style="color: grey">(c0494ff)</span></li>
<li>src/completion/katecompletionmodel.cpp <span style="color: grey">(b48c91c)</span></li>
<li>src/completion/katekeywordcompletion.cpp <span style="color: grey">(f1ad42c)</span></li>
<li>src/completion/katewordcompletion.cpp <span style="color: grey">(925b381)</span></li>
<li>src/dialogs/katedialogs.cpp <span style="color: grey">(0d44f97)</span></li>
<li>src/document/katedocument.cpp <span style="color: grey">(ef96a17)</span></li>
<li>src/export/abstractexporter.h <span style="color: grey">(cc014dd)</span></li>
<li>src/export/htmlexporter.cpp <span style="color: grey">(7736a71)</span></li>
<li>src/inputmode/kateviinputmode.cpp <span style="color: grey">(1954b2e)</span></li>
<li>src/mode/katemodeconfigpage.cpp <span style="color: grey">(42a75de)</span></li>
<li>src/mode/katemodemanager.cpp <span style="color: grey">(641067f)</span></li>
<li>src/printing/printconfigwidgets.cpp <span style="color: grey">(b082983)</span></li>
<li>src/printing/printpainter.cpp <span style="color: grey">(8368f9e)</span></li>
<li>src/render/katelayoutcache.cpp <span style="color: grey">(957006c)</span></li>
<li>src/render/katerenderer.cpp <span style="color: grey">(b108e10)</span></li>
<li>src/schema/katecolortreewidget.cpp <span style="color: grey">(5b6c32c)</span></li>
<li>src/schema/kateschema.cpp <span style="color: grey">(90c91ef)</span></li>
<li>src/schema/kateschemaconfig.cpp <span style="color: grey">(082fce6)</span></li>
<li>src/schema/katestyletreewidget.cpp <span style="color: grey">(e167ceb)</span></li>
<li>src/script/katecommandlinescript.cpp <span style="color: grey">(afa3efa)</span></li>
<li>src/script/kateindentscript.cpp <span style="color: grey">(2050d4f)</span></li>
<li>src/script/katescript.cpp <span style="color: grey">(3dbc2e1)</span></li>
<li>src/script/katescriptaction.cpp <span style="color: grey">(bf0984e)</span></li>
<li>src/script/katescriptdocument.cpp <span style="color: grey">(c5a1784)</span></li>
<li>src/script/katescripthelpers.cpp <span style="color: grey">(c078614)</span></li>
<li>src/script/katescriptmanager.cpp <span style="color: grey">(4c416d4)</span></li>
<li>src/search/kateplaintextsearch.cpp <span style="color: grey">(5a36577)</span></li>
<li>src/search/kateregexp.cpp <span style="color: grey">(1431f95)</span></li>
<li>src/search/kateregexpsearch.cpp <span style="color: grey">(8eb374b)</span></li>
<li>src/search/katesearchbar.cpp <span style="color: grey">(2e1ee99)</span></li>
<li>src/spellcheck/spellcheckdialog.cpp <span style="color: grey">(531d24f)</span></li>
<li>src/spellcheck/spellingmenu.cpp <span style="color: grey">(2319680)</span></li>
<li>src/swapfile/kateswapdiffcreator.cpp <span style="color: grey">(ac09363)</span></li>
<li>src/swapfile/kateswapfile.cpp <span style="color: grey">(f716af9)</span></li>
<li>src/syntax/data/katehighlightingindexer.cpp <span style="color: grey">(d9b0d65)</span></li>
<li>src/syntax/katehighlight.cpp <span style="color: grey">(c3412f7)</span></li>
<li>src/syntax/katehighlighthelpers.cpp <span style="color: grey">(e953d23)</span></li>
<li>src/syntax/katehighlightingcmds.h <span style="color: grey">(802c0f9)</span></li>
<li>src/syntax/katesyntaxdocument.cpp <span style="color: grey">(15d629b)</span></li>
<li>src/syntax/katesyntaxmanager.cpp <span style="color: grey">(4d09fa3)</span></li>
<li>src/undo/kateundomanager.cpp <span style="color: grey">(cc7366c)</span></li>
<li>src/utils/attribute.cpp <span style="color: grey">(130c496)</span></li>
<li>src/utils/katebookmarks.cpp <span style="color: grey">(2fcf924)</span></li>
<li>src/utils/katecmd.cpp <span style="color: grey">(462d4fd)</span></li>
<li>src/utils/katecmds.h <span style="color: grey">(d02e700)</span></li>
<li>src/utils/katecmds.cpp <span style="color: grey">(2fd3a38)</span></li>
<li>src/utils/katecommandrangeexpressionparser.cpp <span style="color: grey">(f57cb45)</span></li>
<li>src/utils/kateconfig.cpp <span style="color: grey">(abf30cc)</span></li>
<li>src/utils/kateglobal.cpp <span style="color: grey">(66b70e2)</span></li>
<li>src/utils/katesedcmd.h <span style="color: grey">(eb61d32)</span></li>
<li>src/utils/katesedcmd.cpp <span style="color: grey">(062a65e)</span></li>
<li>src/utils/ktexteditor.cpp <span style="color: grey">(815a40e)</span></li>
<li>src/variableeditor/katehelpbutton.cpp <span style="color: grey">(a0e1914)</span></li>
<li>src/variableeditor/variableitem.cpp <span style="color: grey">(b0e0a7b)</span></li>
<li>src/variableeditor/variablelineedit.cpp <span style="color: grey">(2a1af83)</span></li>
<li>src/variableeditor/variablelistview.cpp <span style="color: grey">(7316a7f)</span></li>
<li>src/view/kateview.cpp <span style="color: grey">(7e828fe)</span></li>
<li>src/view/kateviewhelpers.cpp <span style="color: grey">(fc171f3)</span></li>
<li>src/view/kateviewinternal.cpp <span style="color: grey">(f968a87)</span></li>
<li>src/vimode/appcommands.cpp <span style="color: grey">(2708487)</span></li>
<li>src/vimode/cmds.h <span style="color: grey">(03fc39f)</span></li>
<li>src/vimode/cmds.cpp <span style="color: grey">(7804af4)</span></li>
<li>src/vimode/commandrangeexpressionparser.cpp <span style="color: grey">(94e00c5)</span></li>
<li>src/vimode/config/configtab.cpp <span style="color: grey">(8074327)</span></li>
<li>src/vimode/emulatedcommandbar.cpp <span style="color: grey">(e876b7a)</span></li>
<li>src/vimode/inputmodemanager.cpp <span style="color: grey">(5f797a0)</span></li>
<li>src/vimode/keyparser.cpp <span style="color: grey">(99f6fbf)</span></li>
<li>src/vimode/lastchangerecorder.cpp <span style="color: grey">(e7b4d43)</span></li>
<li>src/vimode/macros.cpp <span style="color: grey">(b96c099)</span></li>
<li>src/vimode/mappings.cpp <span style="color: grey">(82388cf)</span></li>
<li>src/vimode/modes/insertvimode.cpp <span style="color: grey">(ed71cd4)</span></li>
<li>src/vimode/modes/modebase.cpp <span style="color: grey">(5016b96)</span></li>
<li>src/vimode/modes/normalvimode.cpp <span style="color: grey">(c0eaf40)</span></li>
<li>src/vimode/modes/visualvimode.cpp <span style="color: grey">(c58277b)</span></li>
<li>src/vimode/searcher.cpp <span style="color: grey">(133ff9b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126765/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>