Review Request 126723: Add wrapper for polkit_system_bus_name_get_user_sync

[Hrvoje Senjan]

> On Jan. 12, 2016, 10:43 a.m., Matthias Klumpp wrote:
> > Patch looks good - normally I would say that the build-deps need to be bumped to request an appropriate Polkit version (0.113), but e.g. Debian backports this change to the older 0.105 release - and that seems to be quite common.
> > So I am not sure about the best solution (bump dep upstream have it patched downstream, or just leave it the way it is and do not require a higher version number).
> 
> Martin Gräßlin wrote:
>     I didn't even realize that it requires a higher version as I'm running Debian and just use what's available. As I don't want the change to be disruptive for devs I think not increasing the build-dep is better.
> 
> Hrvoje Senjan wrote:
>     IMO, rasing te dep is better, as people will wonder why they have polkit-qt-1 not compiling out of the sudden.
>     If downstreams will patch polkit to have the new function, they can just as well patch polkit-qt-1 not to require 0.113.
> 
> Martin Gräßlin wrote:
>     > If downstreams will patch polkit to have the new function, they can just as well patch polkit-qt-1 not to require 0.113.
>     
>     my concern is more about our devs than downstreams. E.g. Debian doesn't have the 0.113, so all devs running Debian based systems will get a missing dependency although it would compile just fine.

I understand, but that it compiles is only by chance. At least a comment in the code would be nice if the req. version won't be bumped.


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126723/#review90956
-----------------------------------------------------------


On Jan. 12, 2016, 10:09 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126723/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2016, 10:09 a.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and Matthias Klumpp.
> 
> 
> Repository: polkit-qt-1
> 
> 
> Description
> -------
> 
> This adds a new method to SystemBusNameSubject to get to the
> UnixUserIdentity for the subject.
> 
> 
> Diffs
> -----
> 
>   core/polkitqt1-subject.h 4c7a22bae51a501f9aed2eadac0579baea174d0d 
>   core/polkitqt1-subject.cpp f0d69c647f00728525ee78e946a938f270ddb300 
> 
> Diff: https://git.reviewboard.kde.org/r/126723/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160112/9e465a9c/attachment.html>