<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126723/">https://git.reviewboard.kde.org/r/126723/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 12th, 2016, 10:43 a.m. CET, <b>Matthias Klumpp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch looks good - normally I would say that the build-deps need to be bumped to request an appropriate Polkit version (0.113), but e.g. Debian backports this change to the older 0.105 release - and that seems to be quite common.
So I am not sure about the best solution (bump dep upstream have it patched downstream, or just leave it the way it is and do not require a higher version number).</p></pre>
</blockquote>
<p>On January 12th, 2016, 10:47 a.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't even realize that it requires a higher version as I'm running Debian and just use what's available. As I don't want the change to be disruptive for devs I think not increasing the build-dep is better.</p></pre>
</blockquote>
<p>On January 12th, 2016, 11:08 a.m. CET, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">IMO, rasing te dep is better, as people will wonder why they have polkit-qt-1 not compiling out of the sudden.
If downstreams will patch polkit to have the new function, they can just as well patch polkit-qt-1 not to require 0.113.</p></pre>
</blockquote>
<p>On January 12th, 2016, 11:15 a.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If downstreams will patch polkit to have the new function, they can just as well patch polkit-qt-1 not to require 0.113.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">my concern is more about our devs than downstreams. E.g. Debian doesn't have the 0.113, so all devs running Debian based systems will get a missing dependency although it would compile just fine.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I understand, but that it compiles is only by chance. At least a comment in the code would be nice if the req. version won't be bumped.</p></pre>
<br />
<p>- Hrvoje</p>
<br />
<p>On January 12th, 2016, 10:09 a.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, David Edmundson, Hrvoje Senjan, and Matthias Klumpp.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 12, 2016, 10:09 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
polkit-qt-1
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a new method to SystemBusNameSubject to get to the
UnixUserIdentity for the subject.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/polkitqt1-subject.h <span style="color: grey">(4c7a22bae51a501f9aed2eadac0579baea174d0d)</span></li>
<li>core/polkitqt1-subject.cpp <span style="color: grey">(f0d69c647f00728525ee78e946a938f270ddb300)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126723/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>