Review Request 127209: Fix some issues found by Coverity

Lamarque Souza lamarque at kde.org
Sun Feb 28 20:59:31 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127209/#review92862
-----------------------------------------------------------




src/lib/kaboutdata.cpp (line 993)
<https://git.reviewboard.kde.org/r/127209/#comment63332>

    I think you must change the second "%s" to "%1" here, otherwise the value returned by qAppName() will be added to the string created by QCoreApplication::translate().



src/lib/kaboutdata.cpp (line 1006)
<https://git.reviewboard.kde.org/r/127209/#comment63333>

    Same here.


- Lamarque Souza


On Feb. 28, 2016, 7:46 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127209/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2016, 7:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Mostly initializing values and using printf() correctly.
> 
> 
> Diffs
> -----
> 
>   src/lib/io/kdirwatch.cpp f2fd3b8 
>   src/lib/io/kprocess_p.h 70fe91f 
>   src/lib/kaboutdata.cpp a220977 
>   src/lib/randomness/krandom.cpp bdbdec6 
>   src/lib/util/kformatprivate.cpp 3d98007 
> 
> Diff: https://git.reviewboard.kde.org/r/127209/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160228/16f0191b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list