<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127209/">https://git.reviewboard.kde.org/r/127209/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127209/diff/1/?file=445878#file445878line993" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/kaboutdata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">992</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">printf</span><span class="p">(</span><span class="s">"%s</span><span class="se">\n</span><span class="s">"</span><span class="p">,</span> <span class="n">qPrintable</span><span class="p">(</span><span class="n">QCoreApplication</span><span class="o">::</span><span class="n">translate</span><span class="p">(</span><span class="s">"KAboutData CLI"</span><span class="p">,</span> <span class="s">"%s was written by:"</span><span class="p">)<span class="hl">),</span></span><span class="hl"> </span><span class="n"><span class="hl">qPrintable</span></span><span class="p">(</span><span class="n">qAppName</span><span class="p">()));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">993</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">printf</span><span class="p">(</span><span class="s">"%s</span><span class="se">\n</span><span class="s">"</span><span class="p">,</span> <span class="n">qPrintable</span><span class="p">(</span><span class="n">QCoreApplication</span><span class="o">::</span><span class="n">translate</span><span class="p">(</span><span class="s">"KAboutData CLI"</span><span class="p">,</span> <span class="s">"%s was written by:"</span><span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">arg</span></span><span class="p">(</span><span class="n">qAppName</span><span class="p">()))<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think you must change the second "%s" to "%1" here, otherwise the value returned by qAppName() will be added to the string created by QCoreApplication::translate().</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/127209/diff/1/?file=445878#file445878line1006" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/kaboutdata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1005</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">printf</span><span class="p">(</span><span class="s">"%s</span><span class="se">\n</span><span class="s">"</span><span class="p">,</span> <span class="n">qPrintable</span><span class="p">(</span><span class="n">QCoreApplication</span><span class="o">::</span><span class="n">translate</span><span class="p">(</span><span class="s">"KAboutData CLI"</span><span class="p">,</span> <span class="s">"Please report bugs to %s."</span><span class="p">)<span class="hl">),</span></span><span class="hl"> </span><span class="n"><span class="hl">qPrintable</span></span><span class="p">(</span><span class="n">bugAddress</span><span class="p">()));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1006</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">printf</span><span class="p">(</span><span class="s">"%s</span><span class="se">\n</span><span class="s">"</span><span class="p">,</span> <span class="n">qPrintable</span><span class="p">(</span><span class="n">QCoreApplication</span><span class="o">::</span><span class="n">translate</span><span class="p">(</span><span class="s">"KAboutData CLI"</span><span class="p">,</span> <span class="s">"Please report bugs to %s."</span><span class="p">)<span class="hl">.</span></span><span class="n"><span class="hl">arg</span></span><span class="p">(</span><span class="n">bugAddress</span><span class="p">()))<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Same here.</p></pre>
</div>
</div>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On February 28th, 2016, 7:46 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2016, 7:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Mostly initializing values and using printf() correctly.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/io/kdirwatch.cpp <span style="color: grey">(f2fd3b8)</span></li>
<li>src/lib/io/kprocess_p.h <span style="color: grey">(70fe91f)</span></li>
<li>src/lib/kaboutdata.cpp <span style="color: grey">(a220977)</span></li>
<li>src/lib/randomness/krandom.cpp <span style="color: grey">(bdbdec6)</span></li>
<li>src/lib/util/kformatprivate.cpp <span style="color: grey">(3d98007)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127209/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>