Review Request 127164: Add actionType to the declarative plugin

Martin Klapetek martin.klapetek at gmail.com
Wed Feb 24 01:57:57 UTC 2016



> On Feb. 24, 2016, 1:47 a.m., Aleix Pol Gonzalez wrote:
> > What does it look like on the code?
> > 
> > `ActionTypeWrapper.TextChatAction` might be awkward.

KPeople.ActionType.TextChatAction


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127164/#review92701
-----------------------------------------------------------


On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127164/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> -------
> 
> The KPeople::ActionType is just a namespaced enum, so here's a wrapper
> that makes it usable from QML
> 
> 
> Diffs
> -----
> 
>   src/declarative/peopleqmlplugin.cpp 1e0516a 
> 
> Diff: https://git.reviewboard.kde.org/r/127164/diff/
> 
> 
> Testing
> -------
> 
> Works all good.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160224/b2706345/attachment.html>


More information about the Kde-frameworks-devel mailing list