Review Request 127164: Add actionType to the declarative plugin
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Feb 24 00:47:49 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127164/#review92701
-----------------------------------------------------------
What does it look like on the code?
`ActionTypeWrapper.TextChatAction` might be awkward.
- Aleix Pol Gonzalez
On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127164/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2016, 12:29 a.m.)
>
>
> Review request for KDE Frameworks and KDEPIM.
>
>
> Repository: kpeople
>
>
> Description
> -------
>
> The KPeople::ActionType is just a namespaced enum, so here's a wrapper
> that makes it usable from QML
>
>
> Diffs
> -----
>
> src/declarative/peopleqmlplugin.cpp 1e0516a
>
> Diff: https://git.reviewboard.kde.org/r/127164/diff/
>
>
> Testing
> -------
>
> Works all good.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160224/eade074f/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list