Proposal for moving KColorScheme from KConfigWidgets to KGuiAddons

Andreas Cord-Landwehr cordlandwehr at kde.org
Sat Feb 20 13:57:32 UTC 2016


Thanks, that's actually the consequence I completely oversaw...
With this in mind, I am coming to the same conclusion. Considering the 
alternatives, the only somehow reasonable solution IMO would be  to move 
KColorScheme "up" to KIconThemes. However, that place looks similar "unfitting" 
for that class IMO. And Secondly, it would drag the KIconThemes dependency for 
all of the many places where KColorScheme is used... So, I am not sure if it 
would be worth the effort.

Thus, let's discard my proposal.

Cheers,
Andreas

On Saturday, February 20, 2016 12:50:29 PM CET David Faure wrote:
> On Saturday 20 February 2016 11:22:48 Andreas Cord-Landwehr wrote:
> > Hi, I want to propose to move the KColorScheme class from the
> > KConfigWidgets famework to the KGuiAddons framework.
> 
> Impossible, this would require adding a dependency on KConfig for
> KGuiAddons.
> > Reasons:
> > * that would reduce dependencies of KIconThemes and make it
> > 
> >   - a Tier 2 framework (currently Tier 3) and
> 
> It wouldn't:  KConfig | <whatever contains KColorScheme> | KIconThemes =>
> tier3
> 
> Unless KColorScheme is moved "up" to KIconThemes, but I don't know if this
> makes sense for other users of KColorScheme.
> 
> Or KColorScheme is moved "down" to KConfig, but it also uses kcolorutils
> from KGuiAddons so that's not an option.
> 
> > * KGuiAddons seems to be the much more logical place for this class in my
> > opinion
> 
> It would be, if it wasn't built on top of KConfig.




More information about the Kde-frameworks-devel mailing list