Review Request 127093: Drop KDocTools requirement

Alex Merry alex.merry at kde.org
Fri Feb 19 18:57:09 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127093/#review92570
-----------------------------------------------------------




CMakeLists.txt (line 32)
<https://git.reviewboard.kde.org/r/127093/#comment63114>

    You should set the package properties to say what it is needed for (and maybe make it RECOMMENDED?). See KF5Completion below.


- Alex Merry


On Feb. 18, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127093/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 10:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> -------
> 
> Like in many other frameworks.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt bbec850 
> 
> Diff: https://git.reviewboard.kde.org/r/127093/diff/
> 
> 
> Testing
> -------
> 
> Builds with and without kdoctools.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160219/74ef5a1c/attachment.html>


More information about the Kde-frameworks-devel mailing list