Review Request 127044: Show a warning if there's an error in the Engine

Aleix Pol Gonzalez aleixpol at kde.org
Sun Feb 14 23:28:50 UTC 2016



> On Feb. 13, 2016, 7:31 p.m., David Faure wrote:
> > That's a start, for debugging. The question is, should the user be notified too, in some way?

True, I'll leave that up to the maintainer, especially given it might mean changes in the UI.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127044/#review92325
-----------------------------------------------------------


On Feb. 15, 2016, 12:28 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127044/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2016, 12:28 a.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> So that we can know what's going on if things don't go smoothly.
> 
> Note the signal used to be emitted but nobody was listening to it.
> 
> 
> Diffs
> -----
> 
>   src/downloadmanager.h 1990ef1 
>   src/downloadmanager.cpp c99c524 
> 
> Diff: https://git.reviewboard.kde.org/r/127044/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160214/3a7d4bc4/attachment.html>


More information about the Kde-frameworks-devel mailing list