Review Request 127044: Show a warning if there's an error in the Engine

David Faure faure at kde.org
Sat Feb 13 18:31:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127044/#review92325
-----------------------------------------------------------


Ship it!




That's a start, for debugging. The question is, should the user be notified too, in some way?

- David Faure


On Feb. 11, 2016, 5:45 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127044/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2016, 5:45 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> So that we can know what's going on if things don't go smoothly.
> 
> Note the signal used to be emitted but nobody was listening to it.
> 
> 
> Diffs
> -----
> 
>   src/downloadmanager.h 1990ef1 
>   src/downloadmanager.cpp c99c524 
> 
> Diff: https://git.reviewboard.kde.org/r/127044/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160213/72dadc71/attachment.html>


More information about the Kde-frameworks-devel mailing list