Review Request 126945: Don't call exec() from QML

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126945/
-----------------------------------------------------------

(Updated Feb. 2, 2016, 5:23 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 6b83071705add65a5c0b4cf1b808c8ae8137967b by David Edmundson to branch master.


Bugs: 357435
    http://bugs.kde.org/show_bug.cgi?id=357435


Repository: kactivities


Description
-------

This is dangerous and leads to crashes as the QML processing still
continues in the new event loop.

Besides, one should never block the plasmashell UI anyway.

Also as far as I can see, no-one deleted the exec'd dialog and so it was leaking memory too.

BUG: 357435


Diffs
-----

  src/workspace/settings/imports/activitysettings.cpp e673ec4950f34eaca91e06f410a69e125ef4faee 

Diff: https://git.reviewboard.kde.org/r/126945/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160202/2b34e7b7/attachment.html>