Review Request 126926: Clean up dependencies for KDeclarative/QuickAddons
David Edmundson
david at davidedmundson.co.uk
Mon Feb 1 19:11:01 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126926/#review91871
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Jan. 30, 2016, 10:53 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126926/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2016, 10:53 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdeclarative
>
>
> Description
> -------
>
> They were copy-pasted from somewhere else.
> Also Qt5::Quick is part of the public API.
>
>
> Diffs
> -----
>
> KF5DeclarativeConfig.cmake.in 3867451
> src/quickaddons/CMakeLists.txt 8dc431f
> src/quickaddons/configmodule.cpp f739469
>
> Diff: https://git.reviewboard.kde.org/r/126926/diff/
>
>
> Testing
> -------
>
> Still builds, tests still pass.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160201/2a3fa6e1/attachment.html>
More information about the Kde-frameworks-devel
mailing list