Review Request 126945: Don't call exec() from QML

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126945/#review91935
-----------------------------------------------------------




src/workspace/settings/imports/dialog.cpp (line 142)
<https://git.reviewboard.kde.org/r/126945/#comment62732>

    this is a very bad idea. Setting this attribute in a ctor prevents you from ever creating the dialog on the stack. Or well - it doesn't prevent you from doing so, but it will crash on exit - always. I suggest you set that from the outside whereever you are initializing the dialog. Alternatively, create a static function to create, initialize and show the dialog in a non-blocking manner.


- Milian Wolff


On Feb. 1, 2016, 6:03 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126945/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2016, 6:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 357435
>     http://bugs.kde.org/show_bug.cgi?id=357435
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> This is dangerous and leads to crashes as the QML processing still
> continues in the new event loop.
> 
> Besides, one should never block the plasmashell UI anyway.
> 
> Also as far as I can see, no-one deleted the exec'd dialog and so it was leaking memory too.
> 
> BUG: 357435
> 
> 
> Diffs
> -----
> 
>   src/workspace/settings/imports/activitysettings.cpp e673ec4950f34eaca91e06f410a69e125ef4faee 
>   src/workspace/settings/imports/dialog.cpp ec496fda6150d59f285eba6f1a5447e672aa0214 
> 
> Diff: https://git.reviewboard.kde.org/r/126945/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160202/a7faec52/attachment.html>