Review Request 126945: Don't call exec() from QML

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126945/
-----------------------------------------------------------

Review request for KDE Frameworks.


Bugs: 357435
    http://bugs.kde.org/show_bug.cgi?id=357435


Repository: kactivities


Description
-------

This is dangerous and leads to crashes as the QML processing still
continues in the new event loop.

Besides, one should never block the plasmashell UI anyway.

Also as far as I can see, no-one deleted the exec'd dialog and so it was leaking memory too.

BUG: 357435


Diffs
-----

  src/workspace/settings/imports/activitysettings.cpp e673ec4950f34eaca91e06f410a69e125ef4faee 
  src/workspace/settings/imports/dialog.cpp ec496fda6150d59f285eba6f1a5447e672aa0214 

Diff: https://git.reviewboard.kde.org/r/126945/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160201/5e58a676/attachment.html>