Mac: kbuildsycoca5 and kded5 deadloop *somewhere* after upgrading to Qt 5.7.1

[David Faure]

On vendredi 30 décembre 2016 19:29:35 CET René J.V. Bertin wrote:
>   frame #17: 0x0000000106a6f89c libKF5Service.5.dylib`bool
> KSycocaUtilsPrivate::visitResourceDirectoryHelper<KBuildSycoca::build(dirna
> me=<unavailable>, visitor=<unavailable>)::$_4>(QString const&,
> KBuildSycoca::build()::$_4) + 348 at ksycocautils_p.h:47 <snip>

OK that recursion is fixed in https://git.reviewboard.kde.org/r/129733/

Can you check if you still hit an issue?
I'm wondering if the other recursion (the one in 
VFolderMenu::loadApplications) hits you as well, the fix is only for the 
recursive timestamp checking, not for the code that actually does the parsing.

Actually, you probably won't hit the issue there because the code in 
vfoldermenu says:

 if (fi.isDir() && !fi.isBundle()) {

which makes sense if we don't want to go into bundles to look for application 
desktop files. So we might want to do in sycocautils_p.h as well.

Maybe both should say

 if (fi.isDir() && !fi.isSymLink() && !fi.isBundle()) {


-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5