Review Request 129716: Improve installation process of KPackage bundles

Aleix Pol Gonzalez aleixpol at kde.org
Thu Dec 29 00:25:11 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129716/
-----------------------------------------------------------

(Updated Dec. 29, 2016, 12:25 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit e6d72cb9df6f55b3f463a5acfcad6a7bafe4bd81 by Aleix Pol to branch master.


Repository: kpackage


Description
-------

When parsing the desktop files, pass together the kpackage-generic.desktop service type, so that the parser knows its intrinsic types (most especially `X-KPackage-Dependencies` which is in fact added now). This is important because otherwise we get warnings when we extract the value when the package is a desktop file.

This would be much less of a problem if desktop service types could be extended, but it's not the case at the moment.


Diffs
-----

  src/kpackage/data/servicetypes/kpackage-generic.desktop 879d3b2 
  src/kpackage/package.cpp c032e6e 
  src/kpackage/private/packagejobthread.cpp 8697341 

Diff: https://git.reviewboard.kde.org/r/129716/diff/


Testing
-------

Managed to install llukas's example.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161229/e24e8afe/attachment.html>


More information about the Kde-frameworks-devel mailing list