Review Request 129698: Avoid double look-up

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129698/#review101560
-----------------------------------------------------------


Ship it!




Ship It!

- Marco Martin


On Dec. 23, 2016, 4:09 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129698/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 4:09 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> Instead of using `contains(key);value(key)`, prefer `it=constFind(key)` and `*it`.
> 
> 
> Diffs
> -----
> 
>   src/kpackage/package.cpp 45a8676 
> 
> Diff: https://git.reviewboard.kde.org/r/129698/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass (except for the unrelated two that need fixing from before submitting the patch.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161223/dfa790b3/attachment.html>