Review Request 129698: Avoid double look-up

Aleix Pol Gonzalez aleixpol at kde.org
Fri Dec 23 16:09:18 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129698/
-----------------------------------------------------------

(Updated Dec. 23, 2016, 5:09 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: kpackage


Description
-------

Instead of using `contains(key);value(key)`, prefer `it=constFind(key)` and `*it`.


Diffs
-----

  src/kpackage/package.cpp 45a8676 

Diff: https://git.reviewboard.kde.org/r/129698/diff/


Testing (updated)
-------

Tests still pass (except for the unrelated two that need fixing from before submitting the patch.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161223/5a66d152/attachment.html>


More information about the Kde-frameworks-devel mailing list