Review Request 129660: Fix set up of the KNSCore::Engine when created with an absolute config file path

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129660/
-----------------------------------------------------------

(Updated Dec. 23, 2016, 3:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Jeremy Whiting.


Changes
-------

Submitted with commit 1da38bb7dc33bc8df1cdd23e355d8b95f096c448 by Aleix Pol to branch master.


Repository: knewstuff


Description
-------

`QStrandardPaths::locate` returns `{}` when an absolute path is passed so we can't use it to extract the file's baseName.
Also simplifies a bit the logic that was relying on a class attribute that was only used in that function and we turned into a local variable. It was adding a `':'` that doesn't make sense anymore and I dropped as well.


Diffs
-----

  src/core/engine.h e69dee3 
  src/core/engine.cpp a5758f0 

Diff: https://git.reviewboard.kde.org/r/129660/diff/


Testing
-------

Tests still pass, doesn't choke anymore on a full path (tested from Discover).
Kate, KDevelop still work (listing of installed resources etc)


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161223/2d6ff95c/attachment.html>