Review Request 129660: Fix set up of the KNSCore::Engine when created with an absolute config file path

[Dan Leinir Turthra Jensen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129660/#review101475
-----------------------------------------------------------


Ship it!




Ship It!

- Dan Leinir Turthra Jensen


On Dec. 16, 2016, 4:56 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129660/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2016, 4:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> `QStrandardPaths::locate` returns `{}` when an absolute path is passed so we can't use it to extract the file's baseName.
> Also simplifies a bit the logic that was relying on a class attribute that was only used in that function and we turned into a local variable. It was adding a `':'` that doesn't make sense anymore and I dropped as well.
> 
> 
> Diffs
> -----
> 
>   src/core/engine.h e69dee3 
>   src/core/engine.cpp a5758f0 
> 
> Diff: https://git.reviewboard.kde.org/r/129660/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass, doesn't choke anymore on a full path (tested from Discover).
> Kate, KDevelop still work (listing of installed resources etc)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161216/8beaa022/attachment.html>