Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

[Martin Klapetek]

> On Dec. 17, 2016, 4:53 p.m., Martin Klapetek wrote:
> > Just because it "looks annoying" doesn't mean it doesn't have its use. 
> > 
> > I'll do the git-blame-search for you: https://cgit.kde.org/knotifications.git/commit/?id=3f080d44af41d0158d7b5c51269449e78d5b128f
> 
> Anthony Fieroni wrote:
>     I will correct GwenView too, about me this patch is at wrong place

This is not about Gwenview, this is about safe API that won't break with any other app actually not providing the reason.

Please leave this part alone.


> On Dec. 17, 2016, 4:53 p.m., Martin Klapetek wrote:
> > src/knotificationrestrictions.h, line 97
> > <https://git.reviewboard.kde.org/r/129666/diff/1/?file=487739#file487739line97>
> >
> >     Why?
> 
> Anthony Fieroni wrote:
>     If new contructor is accepted, old one can be omitted.

This is a useful constructor, it doesn't need to be removed. Not all inhibitions *must* include a reason, iirc anyway.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129666/#review101483
-----------------------------------------------------------


On Dec. 17, 2016, 4:48 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129666/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2016, 4:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> "no_reason_specified" looks annoying reason
> 
> 
> Diffs
> -----
> 
>   src/knotificationrestrictions.h e9179ae 
>   src/knotificationrestrictions.cpp 5f5d908 
> 
> Diff: https://git.reviewboard.kde.org/r/129666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161217/a7ac50f5/attachment.html>