Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string
Martin Klapetek
martin.klapetek at gmail.com
Sat Dec 17 15:53:39 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129666/#review101483
-----------------------------------------------------------
Just because it "looks annoying" doesn't mean it doesn't have its use.
I'll do the git-blame-search for you: https://cgit.kde.org/knotifications.git/commit/?id=3f080d44af41d0158d7b5c51269449e78d5b128f
src/knotificationrestrictions.h (line 97)
<https://git.reviewboard.kde.org/r/129666/#comment67932>
Why?
- Martin Klapetek
On Dec. 17, 2016, 4:48 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129666/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2016, 4:48 p.m.)
>
>
> Review request for KDE Frameworks and Martin Klapetek.
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> "no_reason_specified" looks annoying reason
>
>
> Diffs
> -----
>
> src/knotificationrestrictions.h e9179ae
> src/knotificationrestrictions.cpp 5f5d908
>
> Diff: https://git.reviewboard.kde.org/r/129666/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Fieroni
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161217/4041082c/attachment.html>
More information about the Kde-frameworks-devel
mailing list