Review Request 129623: klauncher: remove unnecessary newline from error message
Elvis Angelaccio
elvis.angelaccio at kde.org
Mon Dec 12 10:13:19 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129623/
-----------------------------------------------------------
(Updated Dec. 12, 2016, 10:13 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Changes
-------
Submitted with commit cde4517dc54ce2059a94c1276ebcae7eff1fb952 by Elvis Angelaccio to branch master.
Repository: kinit
Description
-------
I don't see a reason why this error message should end with a line break. This just looks bad, see for example http://i.imgur.com/26Y6Xix.png (note that the message in this screenshot has also other problems, see https://git.reviewboard.kde.org/r/129625/)
Diffs
-----
src/klauncher/klauncher.cpp f1727df17d29882d7631f8e89e672d67d1d47add
Diff: https://git.reviewboard.kde.org/r/129623/diff/
Testing
-------
Thanks,
Elvis Angelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161212/776d5733/attachment.html>
More information about the Kde-frameworks-devel
mailing list