Review Request 129623: klauncher: remove unnecessary newline from error message
Aleix Pol Gonzalez
aleixpol at kde.org
Sun Dec 11 23:32:39 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129623/#review101371
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 7, 2016, 8:12 p.m., Elvis Angelaccio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129623/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 8:12 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kinit
>
>
> Description
> -------
>
> I don't see a reason why this error message should end with a line break. This just looks bad, see for example http://i.imgur.com/26Y6Xix.png (note that the message in this screenshot has also other problems, see https://git.reviewboard.kde.org/r/129625/)
>
>
> Diffs
> -----
>
> src/klauncher/klauncher.cpp f1727df17d29882d7631f8e89e672d67d1d47add
>
> Diff: https://git.reviewboard.kde.org/r/129623/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Elvis Angelaccio
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161211/3da828ac/attachment.html>
More information about the Kde-frameworks-devel
mailing list