Review Request 129617: Restore the "Embeddable Image Viewer" provided by KHTML

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129617/
-----------------------------------------------------------

(Updated Dec. 6, 2016, 6:53 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
-------

Submitted with commit 842ac3256137b0d4fde129844ff6d5aac9da0090 by Jonathan Marten to branch master.


Repository: khtml


Description
-------

This is currently built and installed, but it is not usable because it needed to be converted to the new plugin system.  Trying to use the viewer gives the standard Qt message "Failed to extract plugin meta data...".

This change uses kservice_desktop_to_json and K_PLUGIN_FACTORY_WITH_JSON to embed the plugin data as is now required, eliminating the KHTMLImageFactory.

Yes, the viewer is primitive... but is ought to be made to work as part of a basic installation, as it is the only image viewer part available if nether gwenview nor okular is installed.


Diffs
-----

  src/CMakeLists.txt 99b6ce6e 
  src/khtmlimage.cpp 2f1efe11 
  src/khtmlimage.desktop 00ccd72a 
  src/khtmlimage.h eaaf5c76 
  src/khtmlimage_init.cpp ff93bb4c 

Diff: https://git.reviewboard.kde.org/r/129617/diff/


Testing
-------

Built khtml with this change, checked operation of the embedded viewer part in Konqueror and other applications.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161206/fee065a9/attachment-0001.html>