Review Request 129617: Restore the "Embeddable Image Viewer" provided by KHTML

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129617/#review101303
-----------------------------------------------------------


Ship it!




Ship It!

- Albert Astals Cid


On Dec. 5, 2016, 3:34 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129617/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 3:34 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: khtml
> 
> 
> Description
> -------
> 
> This is currently built and installed, but it is not usable because it needed to be converted to the new plugin system.  Trying to use the viewer gives the standard Qt message "Failed to extract plugin meta data...".
> 
> This change uses kservice_desktop_to_json and K_PLUGIN_FACTORY_WITH_JSON to embed the plugin data as is now required, eliminating the KHTMLImageFactory.
> 
> Yes, the viewer is primitive... but is ought to be made to work as part of a basic installation, as it is the only image viewer part available if nether gwenview nor okular is installed.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 99b6ce6e 
>   src/khtmlimage.cpp 2f1efe11 
>   src/khtmlimage.desktop 00ccd72a 
>   src/khtmlimage.h eaaf5c76 
>   src/khtmlimage_init.cpp ff93bb4c 
> 
> Diff: https://git.reviewboard.kde.org/r/129617/diff/
> 
> 
> Testing
> -------
> 
> Built khtml with this change, checked operation of the embedded viewer part in Konqueror and other applications.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161205/00f57f8b/attachment.html>