Review Request 129540: DropJob: emit started copy job after creation

[Alex Bikadorov]

> On Dec. 4, 2016, 5:50 p.m., David Faure wrote:
> > I would prefer the subjob to remain an implementation detail. Just like so many other KIO jobs which use other jobs internally.
> > 
> > Instead this code should connect the signals from the subjob to the DropJob signals. Much like FileCopyJobPrivate::connectSubjob() does.

Maybe the description was misleading. I do not only want to monitor the subjob but also have full control over it. I.e. I need the signals/methods

* description()
* percent()
* suspend()
* suspended()
* resume()
* resumed()
* result()
* finisned()
* warning()

Do you really want me to connect/wrap all this?

Also, I don't understand why plasma/kuiserver can have access to the subjob (via KIO::getJobTracker) but my application (Krusader) can't have it.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129540/#review101272
-----------------------------------------------------------


On Nov. 22, 2016, 9:53 p.m., Alex Bikadorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129540/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 9:53 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> For giving an application a chance to monitor the job.
> 
> 
> Diffs
> -----
> 
>   src/widgets/dropjob.h 5c9bf10ecc34282d9acb50cef93e7bc8665cb904 
>   src/widgets/dropjob.cpp 1febd3397ec8e993a9786547da9c381a0f57a1f8 
> 
> Diff: https://git.reviewboard.kde.org/r/129540/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Bikadorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161204/1927c1e7/attachment.html>