Review Request 129540: DropJob: emit started copy job after creation

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129540/#review101272
-----------------------------------------------------------



I would prefer the subjob to remain an implementation detail. Just like so many other KIO jobs which use other jobs internally.

Instead this code should connect the signals from the subjob to the DropJob signals. Much like FileCopyJobPrivate::connectSubjob() does.

- David Faure


On Nov. 22, 2016, 9:53 p.m., Alex Bikadorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129540/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 9:53 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> For giving an application a chance to monitor the job.
> 
> 
> Diffs
> -----
> 
>   src/widgets/dropjob.h 5c9bf10ecc34282d9acb50cef93e7bc8665cb904 
>   src/widgets/dropjob.cpp 1febd3397ec8e993a9786547da9c381a0f57a1f8 
> 
> Diff: https://git.reviewboard.kde.org/r/129540/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Bikadorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20161204/f848a70e/attachment.html>