Review Request 128618: Fix creating symlink in Folder View

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98379
-----------------------------------------------------------



Looks great. Two minor fixes and it's good to go.

I just pushed more autotests with 4d43c8f, please rebase and check they pass with your changes too, but they should.


src/core/copyjob.cpp (line 332)
<https://git.reviewboard.kde.org/r/128618/#comment66277>

    OK, I understand and I like this approach.
    
    In "as" mode we don't need to stat the actual dest URL, better stat the parent directory which is more likely to exist.
    
    It's faster (one stat() instead of two) and simpler.
    
    Excellent strategy.



src/core/copyjob.cpp (line 411)
<https://git.reviewboard.kde.org/r/128618/#comment66276>

    How do you know that the dest file doesn't exist? Maybe it does exist...
    
    AFAICS it all works just fine without setting destinationState, anyway. It's only used if !m_asMethod.



src/core/copyjob.cpp (line 412)
<https://git.reviewboard.kde.org/r/128618/#comment66278>

    How can we be sure that sLocalPath ends with a '/' ? Surely the kioslave doesn't have to provide it in UDS_LOCAL_PATH, so we'd better add one here (if it doesn't already end with a slash => needs an if()).


- David Faure


On Aug. 13, 2016, 5:27 p.m., Chinmoy Ranjan Pradhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128618/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 5:27 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KIO::link creates symlink when either protocol+host+port+username+password of the source and the link are same or the link is going to be created locally. In case of plasma's folder view none of the above cases are true therefore creating a symlink in folder view plasmoid gives an error.  
> This patch aims to fix this issue.
> 
> 
> Diffs
> -----
> 
>   src/core/copyjob.cpp 8d6ab05 
> 
> Diff: https://git.reviewboard.kde.org/r/128618/diff/
> 
> 
> Testing
> -------
> 
> All tests pass.
> 
> 
> File Attachments
> ----------------
> 
> error message
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160814/91ffbd59/attachment.html>