Review Request 128618: Fix creating symlink in Folder View

Sat Aug 13 17:27:06 UTC 2016

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/
-----------------------------------------------------------

(Updated Aug. 13, 2016, 5:27 p.m.)

Review request for KDE Frameworks and David Faure.

Changes
-------

Tried a slightly different approach.

P.S. the existing unittests still pass.

Repository: kio

Description
-------

KIO::link creates symlink when either protocol+host+port+username+password of the source and the link are same or the link is going to be created locally. In case of plasma's folder view none of the above cases are true therefore creating a symlink in folder view plasmoid gives an error.  
This patch aims to fix this issue.

Diffs (updated)
-----

  src/core/copyjob.cpp 8d6ab05 

Diff: https://git.reviewboard.kde.org/r/128618/diff/

Testing
-------

All tests pass.

File Attachments
----------------

error message
  https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png

Thanks,

Chinmoy Ranjan Pradhan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160813/57800074/attachment.html>