Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

[Garret Wassermann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120000/
-----------------------------------------------------------

(Updated Aug. 1, 2016, 12:01 a.m.)


Review request for KDE Frameworks, Garret Wassermann, John Layt, and Petri Damstén.


Changes
-------

Removed unneeded unitAsString() function from the diff. I originally remember some difficulty getting my testing program to compile without this function, not sure if it was a bug in my program or KUnitConversion back in the day (this was 2 years ago and I unfortunately didn't keep good notes; needless to say I'm much better at this these days). I was able to recompile my test program with unit().symbol() on KF 5.24.0 and it worked just fine, so I think it was a testing function that got stuck in the diff and forgotten. Removed.


Repository: kunitconversion


Description
-------

New Thermal and Electrical Units and Convienience Function for KUnitConversion


Diffs (updated)
-----

  README.md fe8cbe8 
  src/converter.cpp 0a7f862 
  src/electrical_current.cpp PRE-CREATION 
  src/electrical_current_p.h PRE-CREATION 
  src/electrical_resistance.cpp PRE-CREATION 
  src/electrical_resistance_p.h PRE-CREATION 
  src/energy.cpp f525031 
  src/thermal_conductivity.cpp PRE-CREATION 
  src/thermal_conductivity_p.h PRE-CREATION 
  src/thermal_flux.cpp PRE-CREATION 
  src/thermal_flux_p.h PRE-CREATION 
  src/thermal_generation.cpp PRE-CREATION 
  src/thermal_generation_p.h PRE-CREATION 
  src/unit.h e440346 
  src/voltage.cpp PRE-CREATION 
  src/voltage_p.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120000/diff/


Testing
-------

I added some fundamental (base SI) units as well as some common derived units in SI and English/Imperial system, mostly for electrical or thermal units. I also added a simple member function to the Value class, symbolAsString(), to immediately receive the current unit assigned to the Value object as a QString. I was running into issues with my code where doing v.unit()->symbol() wasn't working because I was getting KSharedPointers instead of the object, and the program would just crash. I just wanted the string! So I made a function, which helped with testing of the units.

The new categories work fine under my test program. I was able to convert thermal units back and forth in my test program, so seems ok. The values also appear correct from my tests (as long as I didn't mess anything up by hand!).

First time submitting review, so please let me know if there is something else I should do better next time, thank you.


Thanks,

Garret Wassermann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160801/b77dbf5b/attachment.html>