Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

[Martin Kostolný]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127154/
-----------------------------------------------------------

(Updated Aug. 1, 2016, 5:12 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Edmundson, David Faure, and Marco Martin.


Changes
-------

Submitted with commit 19568657af443b085e4e534f1be96410e75155b3 by Martin Kostolný to branch master.


Repository: kio


Description
-------

We have an option called "Mark partially uploaded files" in System Settings -> Network: Settings -> Connection Preferences -> FTP Options. This one toggles adding ".part" extension to partially transferred files through FTP protocol.

Other KIO slaves (such as SMB, SFTP) has already working code that supports MarkPartial property read from kioslaverc. This patch is just exposing the property from GUI, specifically I've created "Global Options" section (with one checkbox) above existing "FTP Options" section.

Originally I've created a bug report for this: https://bugs.kde.org/show_bug.cgi?id=359636


Diffs
-----

  src/kcms/kio/kioslave.kcfg d34b691 
  src/kcms/kio/netpref.h f7a0abc 
  src/kcms/kio/netpref.cpp 24273a3 

Diff: https://git.reviewboard.kde.org/r/127154/diff/


Testing
-------

Tested toggling MarkPartial on SMB, SFTP slaves.

FISH slave was and still is ignoring it (no .part extension).

I didn't test NFS and others.


Thanks,

Martin Kostolný

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160801/068ca5cf/attachment-0001.html>