Review Request 127765: RFC: Cache global config files

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127765/#review94947
-----------------------------------------------------------



just minor style review, I think that this is cool but needs work as the others said


src/core/kconfig.cpp (line 700)
<https://git.reviewboard.kde.org/r/127765/#comment64458>

    spaces around operators



src/core/kconfig.cpp (line 701)
<https://git.reviewboard.kde.org/r/127765/#comment64457>

    auto?


- Milian Wolff


On April 27, 2016, 4:14 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127765/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 4:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> A next step for my little quest is improving KConfig impact upon start.
> 
> In callgrind terms, 20% of dolphin's startup time is KConfig and 15% is parsing global files, which is essentially loading kdeglobals 70 times. This of course also means that kdeglobals is scattered 70 times in each application's memory space.
> 
> To improve such situation, here's an attempt to cache these. I'm not an expert in KConfig, so feedback is really appreciated [[1]](http://i1.kym-cdn.com/photos/images/facebook/000/234/765/b7e.jpg)
> 
> 
> Diffs
> -----
> 
>   src/core/kconfig.cpp ad52da9 
> 
> Diff: https://git.reviewboard.kde.org/r/127765/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, KConfig becomes 6% of dolphin at load.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160428/3c78b9c0/attachment.html>