Review Request 127765: RFC: Cache global config files

[Matthew Dawson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127765/#review94932
-----------------------------------------------------------



+1 on the concept.  Making things faster for everyone for free is good by me.  But, since it is an optimization we just need to make sure it doesn't regress KConfig.  Albert's point about caching even with changes definitely needs fixing (I don't think a stat call here should negatively affect anything), and I won't be able to review this properly until this weekend.  So this isn't a shipit yet, but I definitely want it in.

One thing to look at, could this be extended to all config files?  So if someone just keeps opening the same config, there is less of a penalty?  If not, that's fine.  Ideally they wouldn't do that in the first place anyways.

- Matthew Dawson


On April 27, 2016, 12:14 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127765/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 12:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> -------
> 
> A next step for my little quest is improving KConfig impact upon start.
> 
> In callgrind terms, 20% of dolphin's startup time is KConfig and 15% is parsing global files, which is essentially loading kdeglobals 70 times. This of course also means that kdeglobals is scattered 70 times in each application's memory space.
> 
> To improve such situation, here's an attempt to cache these. I'm not an expert in KConfig, so feedback is really appreciated [[1]](http://i1.kym-cdn.com/photos/images/facebook/000/234/765/b7e.jpg)
> 
> 
> Diffs
> -----
> 
>   src/core/kconfig.cpp ad52da9 
> 
> Diff: https://git.reviewboard.kde.org/r/127765/diff/
> 
> 
> Testing
> -------
> 
> Tests pass, KConfig becomes 6% of dolphin at load.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160428/53867005/attachment.html>