Review Request 127754: Use kbuildsycoca5 executable that was just built, not the one from the system

Aleix Pol Gonzalez aleixpol at kde.org
Wed Apr 27 11:38:16 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127754/#review94903
-----------------------------------------------------------



Please see this approach: https://git.reviewboard.kde.org/r/127757/

- Aleix Pol Gonzalez


On April 27, 2016, 10:33 a.m., Jos van den Oever wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127754/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 10:33 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> This test was using QStandardPaths::findExecutable to find buildsycoca5. So the test was testing with the wrong buildsycoca5.
> 
> I've added a function findFile() that looks for buildsycoca5 in the build directory.
> 
> 
> Diffs
> -----
> 
>   autotests/ksycoca_xdgdirstest.cpp f879959 
> 
> Diff: https://git.reviewboard.kde.org/r/127754/diff/
> 
> 
> Testing
> -------
> 
> I ran the unit tests. Some now pass for me, but on my system still some are failing.
> 
> 
> Thanks,
> 
> Jos van den Oever
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160427/16b0c194/attachment.html>


More information about the Kde-frameworks-devel mailing list