Review Request 127414: Don't enable acl permissions widget if we don't own the file

David Edmundson david at davidedmundson.co.uk
Thu Apr 7 23:44:58 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127414/
-----------------------------------------------------------

(Updated April 7, 2016, 11:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 549fdb643b171952b5101ae0c7b9f80f361f3845 by David Edmundson to branch master.


Repository: kio


Description
-------

The man page for setfacl says only the file owner or root can change the
permissions, so it would always fail. Better to disable it in the UI.

Patch effectily written by Thomas Pfeiffer.

BUG: 245580


Diffs
-----

  src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 

Diff: https://git.reviewboard.kde.org/r/127414/diff/


Testing
-------

ran kpropertiesdialogtest on a file owned by me, and a file owned by root.

One had the setting Permissions->Advanced->Add Entry enabled, the other did not.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/f4286779/attachment.html>


More information about the Kde-frameworks-devel mailing list