Review Request 127414: Don't enable acl permissions widget if we don't own the file

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127414/#review94417
-----------------------------------------------------------


Ship it!




Makes sense.

- Aleix Pol Gonzalez


On March 17, 2016, 10:47 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127414/
> -----------------------------------------------------------
> 
> (Updated March 17, 2016, 10:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The man page for setfacl says only the file owner or root can change the
> permissions, so it would always fail. Better to disable it in the UI.
> 
> Patch effectily written by Thomas Pfeiffer.
> 
> BUG: 245580
> 
> 
> Diffs
> -----
> 
>   src/widgets/kpropertiesdialog.cpp 59e189fb79e8033d8f8983b19aa914767dac52f6 
> 
> Diff: https://git.reviewboard.kde.org/r/127414/diff/
> 
> 
> Testing
> -------
> 
> ran kpropertiesdialogtest on a file owned by me, and a file owned by root.
> 
> One had the setting Permissions->Advanced->Add Entry enabled, the other did not.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/4cd2cc8f/attachment-0001.html>