Review Request 127604: [kunitconversion] Simplify isConnected

[David Edmundson]

> On April 7, 2016, 8:55 p.m., Kai Uwe Broulik wrote:
> > src/currency.cpp, line 673
> > <https://git.reviewboard.kde.org/r/127604/diff/1/?file=455754#file455754line673>
> >
> >     Are you sure about that?

I was unsure enough that I had to checked :)

qDebug() << "Batman check:" << &manager << reply->parent();
Batman check: QNetworkAccessManager(0x7f39eefb3520) QNetworkAccessManager(0x7f39eefb3520)

Seems so (and it was what the docs say)

So if you ship your version, you don't want your QScopedPointer - as not only is it superflous but you risk getting a double delete if the NetworkAccessManager gets deleted first.


> On April 7, 2016, 8:55 p.m., Kai Uwe Broulik wrote:
> > src/currency.cpp, line 669
> > <https://git.reviewboard.kde.org/r/127604/diff/1/?file=455754#file455754line669>
> >
> >     You already have a NAM here

I think that's just RB missing up the diff as the other commit also changed this area of code.
I'll resubmit this one after you've merged yours.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127604/#review94398
-----------------------------------------------------------


On April 7, 2016, 3:58 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127604/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 3:58 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> Simplify isConnected
> 
> 
> Diffs
> -----
> 
>   src/currency.cpp 3b99644a4d32433c074080ab91d92466a6ccc3a9 
> 
> Diff: https://git.reviewboard.kde.org/r/127604/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/e8a210ef/attachment.html>