Review Request 127604: [kunitconversion] Simplify isConnected

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127604/#review94398
-----------------------------------------------------------




src/currency.cpp (line 637)
<https://git.reviewboard.kde.org/r/127604/#comment64177>

    QNetworkConfigurationManager().isOnline() ?



src/currency.cpp (line 662)
<https://git.reviewboard.kde.org/r/127604/#comment64176>

    You already have a NAM here



src/currency.cpp (line 666)
<https://git.reviewboard.kde.org/r/127604/#comment64178>

    Are you sure about that?


- Kai Uwe Broulik


On April 7, 2016, 3:58 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127604/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 3:58 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> -------
> 
> Simplify isConnected
> 
> 
> Diffs
> -----
> 
>   src/currency.cpp 3b99644a4d32433c074080ab91d92466a6ccc3a9 
> 
> Diff: https://git.reviewboard.kde.org/r/127604/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160407/0085544b/attachment-0001.html>