Review Request 125325: New widget KCollapsibleGroupBox

[Hugo Pereira Da Costa]

> On Sept. 24, 2015, 8:04 a.m., Hugo Pereira Da Costa wrote:
> > +1 on the idea.
> > Note that gtk has such a widget (which looks exactly like yours) since quite some time already

Testing, there are some issues though. The fact for instance that mouse-over and focus are deliberatly merged, and shown on the arrow only is very confusing, at least in breeze, and also oxygen.

To me the header should be rendered more or less like a checkbox, with an arrow in place of the check mark, but with the same mouse-over and focus effects as checkboxes. For breeze (and oxygen at kf5), that would be underlined text. But then this is naturally style dependent. One should investigate further how one can better re-use existing style elements. I'll try to give it a shot locally.


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125325/#review85862
-----------------------------------------------------------


On Sept. 20, 2015, 3:55 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125325/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2015, 3:55 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> A groupbox featuring a clickable header and arrow indicator that can be
> expanded and collapsed to reveal the box content
> 
> Widget features a close and collapse animation and works as expected in
> QtDesigner.
> 
> --
> Screenshot explains what I mean better than the description above.
> 
> I've been given at least 3 mockups from the VDG mockup which feature using this widget, clearly there's a demand for it. 
> 
> It's a bit like QToolBox, except no-one uses it because QToolbox has a weird way of only expanding one at a time, and looks a bit weird so no-one uses it.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 
>   src/kcollapsiblegroupbox.h PRE-CREATION 
>   src/kcollapsiblegroupbox.cpp PRE-CREATION 
>   tests/CMakeLists.txt 180b0ef1f8900247da59112612ee87dd3164c8af 
>   tests/kcollapsiblegroupboxtest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125325/diff/
> 
> 
> Testing
> -------
> 
> Made little test app (see screenshot)
> 
> Wrote QtDesigner plugin, and played with it there.
> 
> 
> File Attachments
> ----------------
> 
> kcollapsiblegroupbox.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/09/20/f9758e22-0043-4876-b462-364c3b2854dc__kcollapsiblegroupbox.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150924/d907676f/attachment.html>