Review Request 125340: Fix crash in UnicodeGroupProber::HandleData with short strings

Albert Astals Cid aacid at kde.org
Tue Sep 22 19:49:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125340/
-----------------------------------------------------------

(Updated Sept. 22, 2015, 7:49 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit 6573d9198f8accece5d6533e4c3f8689e20ca768 by Albert Astals Cid to branch master.


Repository: kcodecs


Description
-------

len needs to be >= 2 since we always access aBuf[1]

https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/87/testReport/junit/%28root%29/TestSuite/encoding_one_char_latin_15_txt_create/


Diffs
-----

  src/probers/UnicodeGroupProber.cpp 0ab5c50 

Diff: https://git.reviewboard.kde.org/r/125340/diff/


Testing
-------


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150922/892e852e/attachment.html>


More information about the Kde-frameworks-devel mailing list