Review Request 125340: Fix crash in UnicodeGroupProber::HandleData with short strings

David Faure faure at kde.org
Tue Sep 22 08:20:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125340/#review85735
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Sept. 21, 2015, 8:23 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125340/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2015, 8:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcodecs
> 
> 
> Description
> -------
> 
> len needs to be >= 2 since we always access aBuf[1]
> 
> https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/87/testReport/junit/%28root%29/TestSuite/encoding_one_char_latin_15_txt_create/
> 
> 
> Diffs
> -----
> 
>   src/probers/UnicodeGroupProber.cpp 0ab5c50 
> 
> Diff: https://git.reviewboard.kde.org/r/125340/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150922/df420bfe/attachment.html>


More information about the Kde-frameworks-devel mailing list