Review Request 125284: make install name of applications.menu file a cached cmake variable

Harald Sitter sitter at kde.org
Mon Sep 21 11:35:00 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125284/
-----------------------------------------------------------

(Updated Sept. 21, 2015, 11:35 a.m.)


Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex Dieter.


Changes
-------

switch from runtime definition to header defintion


Repository: kservice


Description
-------

To not conflict with kde4runtime nor gnome nor xfce, distributions may
choose to have a different name for their applications.menu file.
To enable this without pitchy patching make the installed name fully
parameterized via the cmake variable APPLICATIONS_MENU_NAME.

This is based on the debian/kubuntu patch to rename the file:
http://anonscm.debian.org/cgit/pkg-kde/frameworks/kservice.git/tree/debian/patches/kubuntu_rename-application-menu-file.diff?h=kubuntu_wily_archive&id=de26b631f641b0aa5e2e184443ff6970ed5e8b56


Diffs (updated)
-----

  CMakeLists.txt 958db4a4891a982b7e9a1bd5c903cb4d126e1cdc 
  src/CMakeLists.txt 5ea5b002411a098a0111a6ee552c554ec461cc28 
  src/config-ksycoca.h.cmake f47b1f67383b558c0a99eccb5c24f32b32fdb1db 
  src/sycoca/kbuildsycoca.cpp ccb935012b158ca75f28dbc337bb77b56d748ab5 

Diff: https://git.reviewboard.kde.org/r/125284/diff/


Testing
-------

clean cmake && make && make install
> -- Installing: ./etc/xdg/menus/applications.menu

changed cached var && make && make install
> -- Installing: ./etc/xdg/menus/kf5-applications.menu


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150921/90b83071/attachment.html>


More information about the Kde-frameworks-devel mailing list