Review Request 125284: make install name of applications.menu file a cached cmake variable

[Harald Sitter]

> On Sept. 20, 2015, 6:37 p.m., David Faure wrote:
> > CMakeLists.txt, line 33
> > <https://git.reviewboard.kde.org/r/125284/diff/1/?file=404548#file404548line33>
> >
> >     I'm surprised that this compiles, the double-quotes here usually don't end up in the C++ code, (they get eaten by cmake or make or the shell) - this requires some more backslashes and double-quotes (there are examples in other places of the code)...
> >     
> >     It's simpler to use configure_file() instead, anyway (and it makes the define only visible by the one file which needs it).

Now that you mention it, that stringy definition indeed didn't work some years ago. Best guess is that cmake3 started auto-escaping. Anyway, switching to the existing config file.


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125284/#review85701
-----------------------------------------------------------


On Sept. 17, 2015, 9:32 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125284/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 9:32 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Jonathan Riddell, and Rex Dieter.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> To not conflict with kde4runtime nor gnome nor xfce, distributions may
> choose to have a different name for their applications.menu file.
> To enable this without pitchy patching make the installed name fully
> parameterized via the cmake variable APPLICATIONS_MENU_NAME.
> 
> This is based on the debian/kubuntu patch to rename the file:
> http://anonscm.debian.org/cgit/pkg-kde/frameworks/kservice.git/tree/debian/patches/kubuntu_rename-application-menu-file.diff?h=kubuntu_wily_archive&id=de26b631f641b0aa5e2e184443ff6970ed5e8b56
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 958db4a4891a982b7e9a1bd5c903cb4d126e1cdc 
>   src/CMakeLists.txt 5ea5b002411a098a0111a6ee552c554ec461cc28 
>   src/sycoca/kbuildsycoca.cpp 60a60662ac014ddc73825ca40f604730e0596537 
> 
> Diff: https://git.reviewboard.kde.org/r/125284/diff/
> 
> 
> Testing
> -------
> 
> clean cmake && make && make install
> > -- Installing: ./etc/xdg/menus/applications.menu
> 
> changed cached var && make && make install
> > -- Installing: ./etc/xdg/menus/kf5-applications.menu
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150921/0ecf2155/attachment.html>