Review Request 125314: KBuildSycocaProgressDialog: run kbuildsycoca5 with QProcess.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125314/
-----------------------------------------------------------

(Updated Sept. 20, 2015, 5:36 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Albert Astals Cid.


Changes
-------

Submitted with commit 3a468067c23e7d4fdfcd185883db4ba9ab5c2a0a by David Faure to branch master.


Bugs: 166792
    https://bugs.kde.org/show_bug.cgi?id=166792


Repository: kio


Description
-------

The dbus-callback stuff from kded is unreliable and unnecessary.

And meanwhile I made kbuildsycoca5 work well when called more
than once, the second instance will wait for the first one
and then check if there's anything else to do, otherwise quit early.

Change-Id: I24f62cf1015bdbab1778245f4221f03f40a9bd0f
BUGS: 235486, 166792
REVIEW: 125314
FIXED-IN: 5.15


Diffs
-----

  src/widgets/kbuildsycocaprogressdialog.h 88c5087990c01725e065fc650e63de246b3032e1 
  src/widgets/kbuildsycocaprogressdialog.cpp 78d23dfda174f195e4c7fdfc1e128e83194326f3 

Diff: https://git.reviewboard.kde.org/r/125314/diff/


Testing
-------

kpropertiesdialogtest <path to app desktop file>, changing the comment, clicking OK.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150920/688c50c4/attachment.html>